Re: [PATCH 3/3] hwrng: msm - Add support for prng v2

From: Herbert Xu
Date: Tue Jun 19 2018 - 10:29:16 EST


On Mon, Jun 18, 2018 at 07:42:59PM +0530, Vinod Koul wrote:
> Qcom 8996 and later chips support prng v2 where we need to only
> implement .read callback for hwrng.
>
> Add a new table for v2 which supports this and get version required for
> driver data.
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

Is this really a pseudo-RNG? If so it needs to be moved over to
the algif_rng interface.

hwrng is for true hardware RNGs only, because it may be directly
fed into /dev/random.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt