Re: [PATCH v2 0/5] Expose PCIe AER stats via sysfs

[Bjorn Helgaas]

On Wed, May 23, 2018 at 10:58:03AM -0700, Rajat Jain wrote:
> This patchset exposes the AER stats via the sysfs attributes.
> 
> Patchset v2 has minor changes to v1 based on the review comments,
> no functional change.
> Primarily:
>  * Fix license header
>  * Use tabs instead of spaces
>  * Remove use on unlikely() etc
>  * Move documentation to Documentation/ABI/
> 
> Rajat Jain (5):
>   PCI/AER: Define and allocate aer_stats structure for AER capable
>     devices
>   PCI/AER: Add sysfs stats for AER capable devices
>   PCI/AER: Add sysfs attributes to provide breakdown of AERs
>   PCI/AER: Add sysfs attributes for rootport cumulative stats
>   Documentation/ABI: Add details of PCI AER statistics
> 
>  .../testing/sysfs-bus-pci-devices-aer_stats   | 103 ++++++++++
>  Documentation/PCI/pcieaer-howto.txt           |   5 +
>  drivers/pci/pci-sysfs.c                       |   3 +
>  drivers/pci/pci.h                             |   4 +-
>  drivers/pci/pcie/aer/Makefile                 |   2 +-
>  drivers/pci/pcie/aer/aerdrv.h                 |  15 ++
>  drivers/pci/pcie/aer/aerdrv_core.c            |  11 +
>  drivers/pci/pcie/aer/aerdrv_errprint.c        |   7 +-
>  drivers/pci/pcie/aer/aerdrv_stats.c           | 192 ++++++++++++++++++
>  drivers/pci/probe.c                           |   1 +
>  include/linux/pci.h                           |   3 +
>  11 files changed, 342 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
>  create mode 100644 drivers/pci/pcie/aer/aerdrv_stats.c

I broke this by putting all the AER code in one file in v4.18-rc1,
sorry!  Would you mind rebasing these on top of that?

Since everything AER-related is now in aer.c, I'd suggest putting the
stats code there, too.