Re: [PATCH] MIPS: Octeon: assign bool true/false not 1/0

From: Paul Burton
Date: Tue Jun 19 2018 - 19:28:55 EST


Hi Nicholas,

On Sat, Jun 16, 2018 at 09:26:32AM +0200, Nicholas Mc Guire wrote:
> Booleans should be assigned true/false not 1/0 as comparison is not needed
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> ---
>
> Problem located by scripts/coccinelle/misc/boolinit.cocci
> ./arch/mips/cavium-octeon/octeon-irq.c:817:3-13:
> WARNING: Assignment of bool to 0/1
>
> Patch was compile tested with: cavium_octeon_defconfig
> (with a number of sparse warnings - not related to the proposed change)
>
> Patch is against 4.17.0 (localversion-next is next-20180614)
>
> arch/mips/cavium-octeon/octeon-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to mips-next for 4.19.

Paul