Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage
From: Kees Cook
Date: Wed Jun 20 2018 - 00:44:35 EST
- Next message: kbuild test robot: "include/linux/syscalls.h:211:18: error: 'sys_mmap2' alias between functions of incompatible types 'long int(long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int)' and 'long int(long int, long int, long int, long int, long int, long int)'"
- Previous message: Kees Cook: "Re: [PATCH v2] net: dsa: drop some VLAs in switch.c"
- Next in thread: Andrew Lunn: "Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, May 30, 2018 at 1:57 PM, Andrew Lunn <andrew@xxxxxxx> wrote:
> On Wed, May 30, 2018 at 01:48:30PM -0700, Kees Cook wrote:
>> In the quest to remove all stack VLA usage from the kernel[1], this
>> moves the allocation into struct mdio_mux_gpio_state during probe.
>>
>> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@xxxxxxxxxxxxxx
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> ---
>> v2: allocate array as part of structure (Andrew Lunn)
>
> Hi Kees
>
> This looks much better, thanks.
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Thanks! Who can take this patch? Linus?
-Kees
--
Kees Cook
Pixel Security
- Next message: kbuild test robot: "include/linux/syscalls.h:211:18: error: 'sys_mmap2' alias between functions of incompatible types 'long int(long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int)' and 'long int(long int, long int, long int, long int, long int, long int)'"
- Previous message: Kees Cook: "Re: [PATCH v2] net: dsa: drop some VLAs in switch.c"
- Next in thread: Andrew Lunn: "Re: [PATCH v2] mdio-mux-gpio: Remove VLA usage"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]