Re: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement
From: Martin HundebÃll
Date: Wed Jun 20 2018 - 04:50:37 EST
On 2018-06-20 09:34, Esben Haabendal wrote:
From: Esben Haabendal <eha@xxxxxxxx>
The if statement just above this if/else statement triggers on the same
condition, and then invalidates it.
Signed-off-by: Esben Haabendal <eha@xxxxxxxx>
Cc: Martin HundebÃll <martin@xxxxxxxxxx>
For the entire series:
Acked-by: Martin HundebÃll <martin@xxxxxxxxxx>
---
drivers/spi/spi-fsl-dspi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 0630962ce442..3ca9b9608801 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -593,8 +593,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi)
dspi_pushr |= SPI_PUSHR_EOQ;
if ((dspi->cs_change) && (!dspi->len))
dspi_pushr &= ~SPI_PUSHR_CONT;
- } else if (tx_word && (dspi->len == 1))
- dspi_pushr |= SPI_PUSHR_EOQ;
+ }
regmap_write(dspi->regmap, SPI_PUSHR, dspi_pushr);
--
Kind regards,
Martin HundebÃll
Embedded Linux Consultant
+45 61 65 54 61
martin@xxxxxxxxxx
Geanix IVS
DK39600706