Re: [PATCH v5 0/9] x86: macrofying inline asm for better compilation

[Nadav Amit]

at 3:11 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, Jun 19, 2018 at 12:48:45PM -0700, Nadav Amit wrote:
>> Nadav Amit (9):
>>  Makefile: Prepare for using macros for inline asm
>>  x86: objtool: use asm macro for better compiler decisions
>>  x86: refcount: prevent gcc distortions
>>  x86: alternatives: macrofy locks for better inlining
>>  x86: bug: prevent gcc distortions
>>  x86: prevent inline distortion by paravirt ops
>>  x86: extable: use macros instead of inline assembly
>>  x86: cpufeature: use macros instead of inline assembly
>>  x86: jump-labels: use macros instead of inline assembly
>> 
>> Makefile                               |  9 ++-
>> arch/x86/Makefile                      | 11 ++-
>> arch/x86/include/asm/alternative-asm.h | 20 ++++--
>> arch/x86/include/asm/alternative.h     | 11 +--
>> arch/x86/include/asm/asm.h             | 61 +++++++---------
>> arch/x86/include/asm/bug.h             | 98 +++++++++++++++-----------
>> arch/x86/include/asm/cpufeature.h      | 82 ++++++++++++---------
>> arch/x86/include/asm/jump_label.h      | 65 ++++++++++-------
>> arch/x86/include/asm/paravirt_types.h  | 56 +++++++--------
>> arch/x86/include/asm/refcount.h        | 74 +++++++++++--------
>> arch/x86/kernel/macros.S               | 16 +++++
>> include/asm-generic/bug.h              |  8 +--
>> include/linux/compiler.h               | 56 +++++++++++----
>> scripts/Kbuild.include                 |  4 +-
>> scripts/mod/Makefile                   |  2 +
>> 15 files changed, 340 insertions(+), 233 deletions(-)
>> create mode 100644 arch/x86/kernel/macros.S
> 
> Aside from the one niggle:
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Thanks! I applied your comments for patches 6 & 9. I will send another
version later today.

I have some other patches that address inlining issues and code redundancy
for the alternative mechanism and the RSB stuffing code, but Iâll send them
after this set is applied.

Regards,
Nadav