Re: [PATCH] crypto: testmgr: add test vectors for skein

[Stephan Mueller]

Am Mittwoch, 20. Juni 2018, 19:56:38 CEST schrieb Eric Biggers:

Hi Eric,

> > +		.alg = "skein1024",
> > +		.test = alg_test_hash,
> > +		.fips_allowed = 1,
> 
> Are you sure Skein should be on the "FIPS allowed" list?  I'm not
> particularly familiar with FIPS, but my understanding is that the
> fips_allowed flag is only supposed to be set on specific "approved"
> algorithms.  So if you're unsure, it shouldn't be set.

Skein is definitely not allowed in FIPS mode. Please drop that flag.
> 
> Eric



Ciao
Stephan