Re: [PATCH 4/7] MIPS: boot: correct prerequisite image of vmlinux.*.its

[Masahiro Yamada]

Hi Paul,

2018-06-20 9:22 GMT+09:00 Paul Burton <paul.burton@xxxxxxxx>:
> Hi Masahiro,
>
> Thanks for these - I've applied patches 1-3, 5 & 6 to mips-next for
> 4.19.
>
> On Mon, Apr 16, 2018 at 07:47:44AM -0700, Masahiro Yamada wrote:
>> vmlinux.*.its does not directly depend on $(VMLINUX) but
>> vmlinux.bin.*
>
> This isn't really true - to generate the .its we actually do depend on
> the ELF, which we read the entry address from (entry-y in
> arch/mips/Makefile, provided to arch/mips/boot/Makefile as
> VMLINUX_ENTRY_ADDRESS). In practice $(VMLINUX) is built before this
> makefile is ever invoked anyway, but the dependency is there.
>
> We don't need the vmlinux.bin.* file until we generate the .itb, so it
> should be fine for the .its & .bin steps to be executed in parallel
> which this patch would prevent.


You are right.

Thanks for catching this.




-- 
Best Regards
Masahiro Yamada