Re: [RESEND PATCH] media: helene: fix xtal frequency setting at power on

[Katsuhiro Suzuki]

Hello Mauro,

Ping...

If I got some mistake, please comment it...

Regards,
--
Katsuhiro Suzuki


> -----Original Message-----
> From: Katsuhiro Suzuki <suzuki.katsuhiro@xxxxxxxxxxxxx>
> Sent: Tuesday, May 29, 2018 10:09 AM
> To: Abylay Ospan <aospan@xxxxxxxx>; Mauro Carvalho Chehab
> <mchehab+samsung@xxxxxxxxxx>; linux-media@xxxxxxxxxxxxxxx
> Cc: Masami Hiramatsu <masami.hiramatsu@xxxxxxxxxx>; Jassi Brar
> <jaswinder.singh@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; Suzuki, Katsuhiro/鈴木 勝博
> <suzuki.katsuhiro@xxxxxxxxxxxxx>
> Subject: [RESEND PATCH] media: helene: fix xtal frequency setting at power on
> 
> This patch fixes crystal frequency setting when power on this device.
> 
> Signed-off-by: Katsuhiro Suzuki <suzuki.katsuhiro@xxxxxxxxxxxxx>
> Acked-by: Abylay Ospan <aospan@xxxxxxxx>
> 
> ---
> 
> Changes from before:
>   - Add Abylay's Ack
> 
> ---
>  drivers/media/dvb-frontends/helene.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/helene.c
> b/drivers/media/dvb-frontends/helene.c
> index 0a4f312c4368..8fcf7a00782a 100644
> --- a/drivers/media/dvb-frontends/helene.c
> +++ b/drivers/media/dvb-frontends/helene.c
> @@ -924,7 +924,10 @@ static int helene_x_pon(struct helene_priv *priv)
>  	helene_write_regs(priv, 0x99, cdata, sizeof(cdata));
> 
>  	/* 0x81 - 0x94 */
> -	data[0] = 0x18; /* xtal 24 MHz */
> +	if (priv->xtal == SONY_HELENE_XTAL_16000)
> +		data[0] = 0x10; /* xtal 16 MHz */
> +	else
> +		data[0] = 0x18; /* xtal 24 MHz */
>  	data[1] = (uint8_t)(0x80 | (0x04 & 0x1F)); /* 4 x 25 = 100uA */
>  	data[2] = (uint8_t)(0x80 | (0x26 & 0x7F)); /* 38 x 0.25 = 9.5pF */
>  	data[3] = 0x80; /* REFOUT signal output 500mVpp */
> --
> 2.17.0