Re: [PATCH] staging/typec: fix tcpci_rt1711h build errors

[Heikki Krogerus]

On Wed, Jun 20, 2018 at 05:05:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> Fix Kconfig warning and build errors in staging/typec/rt1711h.c.
> The driver uses I2C interfaces so it should depend on I2C.
> 
> WARNING: unmet direct dependencies detected for TYPEC_TCPCI
>   Depends on [m]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=m]
>   Selected by [y]:
>   - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=y]
> 
> and then:
> drivers/staging/typec/tcpci.o: In function `tcpci_probe':
> ../drivers/staging/typec/tcpci.c:536: undefined reference to `__devm_regmap_init_i2c'
> drivers/staging/typec/tcpci.o: In function `tcpci_i2c_driver_init':
> ../drivers/staging/typec/tcpci.c:593: undefined reference to `i2c_register_driver'
> drivers/staging/typec/tcpci.o: In function `tcpci_i2c_driver_exit':
> ../drivers/staging/typec/tcpci.c:593: undefined reference to `i2c_del_driver'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_check_revision':
> ../drivers/staging/typec/tcpci_rt1711h.c:218: undefined reference to `i2c_smbus_read_word_data'
> ../drivers/staging/typec/tcpci_rt1711h.c:225: undefined reference to `i2c_smbus_read_word_data'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_probe':
> ../drivers/staging/typec/tcpci_rt1711h.c:251: undefined reference to `__devm_regmap_init_i2c'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_init':
> ../drivers/staging/typec/tcpci_rt1711h.c:308: undefined reference to `i2c_register_driver'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_exit':
> ../drivers/staging/typec/tcpci_rt1711h.c:308: undefined reference to `i2c_del_driver'
> 
> Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver")
> 
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: ShuFan Lee <shufan_lee@xxxxxxxxxxx>
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: kbuild-all@xxxxxx

Revieved-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/staging/typec/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-418-rc1.orig/drivers/staging/typec/Kconfig
> +++ lnx-418-rc1/drivers/staging/typec/Kconfig
> @@ -11,6 +11,7 @@ config TYPEC_TCPCI
>  
>  config TYPEC_RT1711H
>  	tristate "Richtek RT1711H Type-C chip driver"
> +	depends on I2C
>  	select TYPEC_TCPCI
>  	help
>  	  Richtek RT1711H Type-C chip driver that works with
> 

Thanks,

-- 
heikki