Re: [PATCH V3 1/7] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

[Daniel Thompson]

On Thu, Jun 21, 2018 at 02:05:59PM +0100, Daniel Thompson wrote:
> On Tue, Jun 19, 2018 at 04:43:36PM +0530, Kiran Gunda wrote:
> > pm8941-wled.c driver is supporting the WLED peripheral
> > on pm8941. Rename it to qcom-wled.c so that it can support
> > WLED on multiple PMICs.
> > 
> > Signed-off-by: Kiran Gunda <kgunda@xxxxxxxxxxxxxx>
> 
> With changes proposed for v4:

Ignore that bit... misremembered the thread to date.

It's just a plain (no caveat):
> Acked-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>


Daniel.


> 
> > ---
> >  .../bindings/leds/backlight/{pm8941-wled.txt => qcom-wled.txt}    | 2 +-
> >  drivers/video/backlight/Kconfig                                   | 8 ++++----
> >  drivers/video/backlight/Makefile                                  | 2 +-
> >  drivers/video/backlight/{pm8941-wled.c => qcom-wled.c}            | 0
> >  4 files changed, 6 insertions(+), 6 deletions(-)
> >  rename Documentation/devicetree/bindings/leds/backlight/{pm8941-wled.txt => qcom-wled.txt} (95%)
> >  rename drivers/video/backlight/{pm8941-wled.c => qcom-wled.c} (100%)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > similarity index 95%
> > rename from Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
> > rename to Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > index e5b294d..fb39e32 100644
> > --- a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
> > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > @@ -1,4 +1,4 @@
> > -Binding for Qualcomm PM8941 WLED driver
> > +Binding for Qualcomm Technologies, Inc. WLED driver
> >  
> >  Required properties:
> >  - compatible: should be "qcom,pm8941-wled"
> > diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> > index 4e1d2ad..8c095e3 100644
> > --- a/drivers/video/backlight/Kconfig
> > +++ b/drivers/video/backlight/Kconfig
> > @@ -299,12 +299,12 @@ config BACKLIGHT_TOSA
> >  	  If you have an Sharp SL-6000 Zaurus say Y to enable a driver
> >  	  for its backlight
> >  
> > -config BACKLIGHT_PM8941_WLED
> > -	tristate "Qualcomm PM8941 WLED Driver"
> > +config BACKLIGHT_QCOM_WLED
> > +	tristate "Qualcomm PMIC WLED Driver"
> >  	select REGMAP
> >  	help
> > -	  If you have the Qualcomm PM8941, say Y to enable a driver for the
> > -	  WLED block.
> > +	  If you have the Qualcomm PMIC, say Y to enable a driver for the
> > +	  WLED block. Currently it supports PM8941 and PMI8998.
> >  
> >  config BACKLIGHT_SAHARA
> >  	tristate "Tabletkiosk Sahara Touch-iT Backlight Driver"
> > diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Makefile
> > index 5e28f01..6fd76ef 100644
> > --- a/drivers/video/backlight/Makefile
> > +++ b/drivers/video/backlight/Makefile
> > @@ -49,8 +49,8 @@ obj-$(CONFIG_BACKLIGHT_OMAP1)		+= omap1_bl.o
> >  obj-$(CONFIG_BACKLIGHT_OT200)		+= ot200_bl.o
> >  obj-$(CONFIG_BACKLIGHT_PANDORA)		+= pandora_bl.o
> >  obj-$(CONFIG_BACKLIGHT_PCF50633)	+= pcf50633-backlight.o
> > -obj-$(CONFIG_BACKLIGHT_PM8941_WLED)	+= pm8941-wled.o
> >  obj-$(CONFIG_BACKLIGHT_PWM)		+= pwm_bl.o
> > +obj-$(CONFIG_BACKLIGHT_QCOM_WLED)	+= qcom-wled.o
> >  obj-$(CONFIG_BACKLIGHT_SAHARA)		+= kb3886_bl.o
> >  obj-$(CONFIG_BACKLIGHT_SKY81452)	+= sky81452-backlight.o
> >  obj-$(CONFIG_BACKLIGHT_TOSA)		+= tosa_bl.o
> > diff --git a/drivers/video/backlight/pm8941-wled.c b/drivers/video/backlight/qcom-wled.c
> > similarity index 100%
> > rename from drivers/video/backlight/pm8941-wled.c
> > rename to drivers/video/backlight/qcom-wled.c
> > -- 
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> >  a Linux Foundation Collaborative Project
> >