Re: [PATCH 0/5]stop normal completion path entering a timeout req

[Bart Van Assche]

On Thu, 2018-06-21 at 10:19 +0200, Christoph Hellwig wrote:
> On Thu, Jun 21, 2018 at 09:43:26AM +0800, jianchao.wang wrote:
> > So we have to preserve the ability of block layer that it could prevent
> > IO completion path from entering a timeout request.
> > 
> > With scsi-debug module, I tried to simulate a scenario where timeout and IO
> > completion path could occur concurrently, the system ran into crash easily.
> 
> Trace, please.  With the latest kernel.  I'm not saying that there
> is nothing to fix, but the mode of never completing once timeout
> requests as currently done is SCSI is clearly broken.

That's not how the SCSI core works.

Bart.