Re: [RFC PATCH 02/16] x86/split_lock: Handle #AC exception for split lock in kernel mode
From: Peter Zijlstra
Date: Thu Jun 21 2018 - 15:47:13 EST
On Sun, May 27, 2018 at 08:45:51AM -0700, Fenghua Yu wrote:
> When #AC exception for split lock is triggered from a kernel instruction,
> by default we don't want the exception to panic the whole system. Instead,
> the exception handler should log the fault information for debug and
> continue the instruction execution.
This should not happen today, did you find any unaligned LOCK insns?
This is a lot of code to 'handle' something that really should not ever
happen. Maybe just WARN and clear the MSR bit, nothing complicated.
Also, fix your "disgusting drug-induced crap" comments.