Re: [PATCH v4 12/12] mfd: cros_ec: Add throttler sub-device

[Brian Norris]

On Wed, Jun 20, 2018 at 06:52:37PM -0700, Matthias Kaehlcke wrote:
> Instantiate the CrOS EC throttler if it is enabled in the kernel
> configuration.
> 
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>

Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>

> ---
> Changes in v4:
> - register throttler in cros_ec_dev.c instead of cros_ec.c
> 
> Changes in v3:
> - patch added to series
> ---
>  drivers/mfd/cros_ec_dev.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index eafd06f62a3a..9e56c2793075 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -383,6 +383,22 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec)
>  	kfree(msg);
>  }
>  
> +static const struct mfd_cell ec_throttler_cells[] = {
> +	{ .name = "cros-ec-throttler" }
> +};
> +
> +static void cros_ec_throttler_register(struct cros_ec_dev *ec)
> +{
> +	int ret;
> +
> +	ret = mfd_add_devices(ec->dev, 0, ec_throttler_cells,
> +			      ARRAY_SIZE(ec_throttler_cells),
> +			      NULL, 0, NULL);
> +	if (ret)
> +		dev_err(ec->dev,
> +			"failed to add cros-ec-throttler device: %d\n", ret);
> +}
> +
>  static int ec_device_probe(struct platform_device *pdev)
>  {
>  	int retval = -ENOMEM;
> @@ -422,6 +438,9 @@ static int ec_device_probe(struct platform_device *pdev)
>  	if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE))
>  		cros_ec_sensors_register(ec);
>  
> +	if (IS_ENABLED(CONFIG_CROS_EC_THROTTLER))
> +		cros_ec_throttler_register(ec);
> +
>  	/* Take control of the lightbar from the EC. */
>  	lb_manual_suspend_ctrl(ec, 1);
>  
> -- 
> 2.18.0.rc2.346.g013aa6912e-goog
>