Re: [PATCH] devres: Add devm_of_iomap()

From: Greg Kroah-Hartman
Date: Fri Jun 22 2018 - 01:09:50 EST


On Fri, Jun 22, 2018 at 02:13:15PM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2018-06-14 at 13:31 +1000, Benjamin Herrenschmidt wrote:
> > There are still quite a few cases where a device might want
> > to get to a different node of the device-tree, obtain the
> > resources and map them.
> >
> > This is generally open coded in drivers which is quite error prone
> >
> > We have of_iomap() and of_io_request_and_map() but they both
> > have shortcomings, such as not returning the size of the
> > resource found (which can be useful) and not being "managed".
> >
> > This adds a devm_of_iomap() that provides all of these and
> > should probably replace uses of the above in most drivers.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > ---
>
> Greg, which tree should this go through ? Rob, ack pls ? :-)
>
> I have dependencies on this coming up... I can put it in the FSI tree
> if you want, it will be part of my next pull request.

Usually new devres patches just go through whatever tree needs it, so no
objection from me for you to take these in your next pull request.

thanks,

greg k-h