Re: [alsa-devel] [PATCH v2 2/2] ASoC: qcom: add sdm845 sound card support

From: Rohit Kumar
Date: Fri Jun 22 2018 - 06:36:40 EST




On 6/21/2018 8:39 PM, Srinivas Kandagatla wrote:


On 21/06/18 13:35, Vinod wrote:
And this one is generic DT parsing and seems quite similar to one in apq8096.c
Can we move these into a lib and use them instead of duplicating.
I totally agree with Vinod, We should probably come up with a library functions something like common.c so that we do not duplicate code.
This code is going be exactly same for most of the SoCs using qdsp.

Sure, I will add a new file, qcom_snd_common.c, which will have these common functions and will update apq8096 and sdm845 machine driver to use
APIs exposed by qcom_snd_common.c

thanks,
srini

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Regards,
Rohit

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.