Re: [PATCH v4 5/7] x86/segments/64: Rename PER_CPU segment to CPU_NUMBER

[Thomas Gleixner]

On Wed, 20 Jun 2018, Chang S. Bae wrote:
> diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c
> index 5b8b556..833e229 100644
> --- a/arch/x86/entry/vdso/vma.c
> +++ b/arch/x86/entry/vdso/vma.c
> @@ -359,7 +359,10 @@ static void vgetcpu_cpu_init(void *arg)
>  	d.p = 1;		/* Present */
>  	d.d = 1;		/* 32-bit */
>  
> -	write_gdt_entry(get_cpu_gdt_rw(cpu), GDT_ENTRY_PER_CPU, &d, DESCTYPE_S);
> +	write_gdt_entry(get_cpu_gdt_rw(cpu),
> +			GDT_ENTRY_CPU_NUMBER,
> +			&d,
> +			DESCTYPE_S);

There is no value in using 4 lines for something which fits in one.

Other than that.

Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>