Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

From: Thomas Gleixner
Date: Fri Jun 22 2018 - 12:18:40 EST


On Fri, 22 Jun 2018, Andy Lutomirski wrote:
> > On Jun 22, 2018, at 8:18 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> >
> >> On Wed, 20 Jun 2018, Chang S. Bae wrote:
> >>
> >> +#ifdef CONFIG_X86_64
> >> +static void setup_cpu_number(int cpu)
> >
> > This function name is really misleading. vdso_setup_cpu_and_node() or
> > something like that clearly tells what this is about.
> >
> Ah. The big secret is that itâs not just vDSO, or at lease hpa wants to
> start using it in the entry code.

Fair enough. Still setup_cpu_number() sucks.

Thanks,

tglx