Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

[Joe Perches]

On Fri, 2018-06-22 at 21:11 +0200, Michael Straube wrote:
> On 06/22/18 19:28, Joe Perches wrote:
> > Although the last memcpy of a fixed mac address could
> > probably use eth_random_addr to reduce the likelihood
> > of mac address collision so maybe
> > 		eth_random_addr(mac_addr);
> Using a random address would be preffered?

mac address duplication is bad, so if there
were 2 instances of this device on the same
ethernet network, yes.

> 
> Thanks for your help and patience.
> Michael