[PATCH] mm/zsmalloc: make several functions and a struct static

From: Colin King
Date: Sun Jun 24 2018 - 17:33:31 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The functions zs_page_isolate, zs_page_migrate, zs_page_putback,
lock_zspage, trylock_zspage and structure zsmalloc_aops are local to
source and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'zs_page_isolate' was not declared. Should it be static?
symbol 'zs_page_migrate' was not declared. Should it be static?
symbol 'zs_page_putback' was not declared. Should it be static?
symbol 'zsmalloc_aops' was not declared. Should it be static?
symbol 'lock_zspage' was not declared. Should it be static?
symbol 'trylock_zspage' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
mm/zsmalloc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index a1a9debb6fc8..900bea99452a 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -928,7 +928,7 @@ static void reset_page(struct page *page)
* To prevent zspage destroy during migration, zspage freeing should
* hold locks of all pages in the zspage.
*/
-void lock_zspage(struct zspage *zspage)
+static void lock_zspage(struct zspage *zspage)
{
struct page *page = get_first_page(zspage);

@@ -937,7 +937,7 @@ void lock_zspage(struct zspage *zspage)
} while ((page = get_next_page(page)) != NULL);
}

-int trylock_zspage(struct zspage *zspage)
+static int trylock_zspage(struct zspage *zspage)
{
struct page *cursor, *fail;

@@ -1906,7 +1906,7 @@ static void replace_sub_page(struct size_class *class, struct zspage *zspage,
__SetPageMovable(newpage, page_mapping(oldpage));
}

-bool zs_page_isolate(struct page *page, isolate_mode_t mode)
+static bool zs_page_isolate(struct page *page, isolate_mode_t mode)
{
struct zs_pool *pool;
struct size_class *class;
@@ -1961,7 +1961,7 @@ bool zs_page_isolate(struct page *page, isolate_mode_t mode)
return true;
}

-int zs_page_migrate(struct address_space *mapping, struct page *newpage,
+static int zs_page_migrate(struct address_space *mapping, struct page *newpage,
struct page *page, enum migrate_mode mode)
{
struct zs_pool *pool;
@@ -2077,7 +2077,7 @@ int zs_page_migrate(struct address_space *mapping, struct page *newpage,
return ret;
}

-void zs_page_putback(struct page *page)
+static void zs_page_putback(struct page *page)
{
struct zs_pool *pool;
struct size_class *class;
@@ -2109,7 +2109,7 @@ void zs_page_putback(struct page *page)
spin_unlock(&class->lock);
}

-const struct address_space_operations zsmalloc_aops = {
+static const struct address_space_operations zsmalloc_aops = {
.isolate_page = zs_page_isolate,
.migratepage = zs_page_migrate,
.putback_page = zs_page_putback,
--
2.17.0