Re: [PATCH v3] staging: pi433: replace simple switch statements
From: Dan Carpenter
Date: Mon Jun 25 2018 - 08:36:58 EST
I'd still prefer if we just removed this abstraction entirely and used
OPMODE_MODE_TRANSMIT everywhere instead of bringing "transmit" into it.
I know that every author thinks their abstraction will definitely be
useful in the future, but generally kernel style is to remove
abstractions.
But I guess this code is an improvement over the original so the patch
is fine.
regards,
dan carpenter