Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()

[Dmitry Vyukov]

On Thu, Jun 21, 2018 at 10:17 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@xxxxxxxxx> wrote:
> On (06/21/18 09:59), Dmitry Vyukov wrote:
>> >
>> >> +       printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
>> >> +               (address < PAGE_SIZE ? "NULL pointer dereference" :
>> >> +               "paging request"), (void *) address);
>> >
>> > Perhaps pr_alert() ?
>>
>> It's the same, right? Make sense.
>
> Right.
>
> In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes,
> so, I think, in general we want to see more pr_foo() and less printk().

Mailed v2 with pr_alert().

Since nobody else commented on single pr_alert() with ternary operator
vs if + 2 pr_alert()'s, I left it intact for now.