Re: [PATCHv2 00/11] atomics: generate atomic headers / instrument arm64

[Peter Zijlstra]

On Mon, Jun 25, 2018 at 11:59:41AM +0100, Mark Rutland wrote:

> That scripting comes to ~900 lines, and replaces ~1700 lines of hand-written
> boilerplate with ~4700 lines of generated code. Some of that increase in line
> count is due to filling in missing portions of the API (e.g. adding all the
> ordering variants to the instrumented atomics), while some of that is due to
> expanding fallbacks in place, and consistently spreading these across multiple
> lines.

> Mark Rutland (10):
>   atomics/x86: reduce arch_cmpxchg64*() instrumentation
>   atomics: simplify cmpxchg() instrumentation
>   atomics/treewide: instrument xchg()
>   atomics: instrument cmpxchg_double*()
>   atomics/treewide: rework ordering barriers
>   atomics: add common header generation files
>   atomics: switch to generated fallbacks
>   atomics: switch to generated atomic-long
>   atomics: switch to generated instrumentation
>   arm64: use instrumented atomics

Awesome work Mark, thanks for doing that!

Aside from the nitpicks I mentioned on IRC (mostly spelling and
Changelog inconsistencies),

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>