Re: checkpatch false positive (IMO): typo detected in truncated commit message
From: Jann Horn
Date: Mon Jun 25 2018 - 11:32:41 EST
On Mon, Jun 25, 2018 at 5:23 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote:
> > Hello!
> >
> > I got the following message from checkpatch:
> >
> > =======
> > $ scripts/checkpatch.pl
> > 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch
> > WARNING: 'calle' may be misspelled - perhaps 'called'?
> > #15:
> > Fixes: 266d07cb1c9a ("netfilter: nf_log: fix sleeping function calle[...]")
> >
> > total: 0 errors, 1 warnings, 0 checks, 20 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> > mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch has
> > style problems, please review.
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
> > =======
> >
> > I believe that it is appropriate here to truncate the commit message
> > of the fixed commit.
>
> It's not.
Looking at a bunch of other recent commits, I'm guessing that the
accepted format is to use the complete commit message, without
linebreaks, even if it goes over 75 columns?