Re: [PATCH v4 09/12] dt-bindings: PM / OPP: add opp-throttlers property

From: Rob Herring
Date: Mon Jun 25 2018 - 11:33:51 EST


On Wed, Jun 20, 2018 at 06:52:34PM -0700, Matthias Kaehlcke wrote:
> The optional opp-throttlers property is used to configure the throttlers
> (see drivers/misc/throttler/*) that use a given OPP to throttle the
> corresponding device(s).
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
> Changes in v4:
> - added 'Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>' tag
>
> Changes in v3:
> - none
>
> Changes in v2:
> - patch added to series
> ---
> Documentation/devicetree/bindings/opp/opp.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
> index c396c4c0af92..747e79740c75 100644
> --- a/Documentation/devicetree/bindings/opp/opp.txt
> +++ b/Documentation/devicetree/bindings/opp/opp.txt
> @@ -170,6 +170,9 @@ Optional properties:
> functioning of the current device at the current OPP (where this property is
> present).
>
> +- opp-throttlers: Array with phandles of throttlers that use this OPP to
> + throttle the corresponding device(s).
> +

I think it would be better to make this a boolean for each OPP entry and
then add "operating-points-v2" property to the EC node to point to the
OPP table. Unless there is some need for a different throttler for each
OPP entry?

Rob