Re: [PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers

[Andy Lutomirski]

On Mon, Jun 25, 2018 at 8:55 AM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.

Whoa there..  Your commit message makes it sound like you're just
changing the return type, but:

>                 if (tsc_pg && vclock_was_used(VCLOCK_HVCLOCK))
> -                       ret = vm_insert_pfn(vma, vmf->address,
> +                       ret = vmf_insert_pfn(vma, vmf->address,
>                                             vmalloc_to_pfn(tsc_pg));
>         }
>
> -       if (ret == 0 || ret == -EBUSY)
> -               return VM_FAULT_NOPAGE;
> -
> -       return VM_FAULT_SIGBUS;
> +       return ret;

You're refactoring the code, too.

Please fix your changelog.