Re: s390 qemu boot failure in -next

From: Georgi Guninski
Date: Tue Jun 26 2018 - 01:55:40 EST


On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote:
> - /* Overwrite parameters in the kernel image, which are "rom" */
> - strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);

> + strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline);

Why not replace strcpy() with strncpy() or snprintf()?
strcpy() may overflow.