RE: [PATCH] fman: don't set node on dpaa-ethernet platform device
From: Madalin-cristian Bucur
Date: Tue Jun 26 2018 - 03:01:05 EST
> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Saturday, June 23, 2018 4:27 AM
> To: bas@xxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; Madalin-cristian Bucur <madalin.bucur@xxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] fman: don't set node on dpaa-ethernet platform device
>
> From: Bas Vermeulen <bas@xxxxxxxxxxxx>
> Date: Thu, 21 Jun 2018 13:42:22 +0200
>
> > Setting dev->node to the mac_node in dpaa_eth_add_device during probe
> > causes the mac_probe to be called again for the dpaa-ethernet.* device
> > that was just added.
> >
> > Fix this by not setting dev->node, as it is not needed.
> >
> > Signed-off-by: Bas Vermeulen <bas@xxxxxxxxxxxx>
>
> This patch doesn't apply to the current sources.
Hi,
The line the patch is trying to remove was added in this commit
commit a1a50c8e4c241a505b7270e1a3c6e50d94e794b1
Author: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Tue Aug 22 15:24:47 2017 -0700
fsl/man: Inherit parent device and of_node
and was already removed in this commit
commit 48167c9ce0b91c068430345bf039c7be23fa2f3f
Author: Madalin Bucur <madalin.bucur@xxxxxxx>
Date: Mon Oct 16 21:36:05 2017 +0300
fsl/fman: remove of_node
Regards,
Madalin