Re: [PATCH] x86: modernize sync_bitops.h

From: Jan Beulich
Date: Tue Jun 26 2018 - 03:26:27 EST


>>> On 26.06.18 at 09:18, <mingo@xxxxxxxxxx> wrote:
> * Jan Beulich <JBeulich@xxxxxxxx> wrote:
>
>> Add missing insn suffixes and use rmwcc.h just like was (more or less)
>> recently done for bitops.h as well.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> arch/x86/include/asm/sync_bitops.h | 34 ++++++++++++----------------------
>> 1 file changed, 12 insertions(+), 22 deletions(-)
>
> Have you verified that a typical x86 vmlinux (with defconfig for example) is the
> same before/after?

It works the same, but the binary is unlikely to be the same with the switch
to condition code asm() outputs.

Jan