Re: [PATCH v2 01/10] tpm/tpm_i2c_infineon: switch to i2c_lock_bus(..., I2C_LOCK_SEGMENT)

From: Jarkko Sakkinen
Date: Tue Jun 26 2018 - 08:05:41 EST


On Tue, 2018-06-26 at 12:07 +0200, Alexander Steffen wrote:
> On 25.06.2018 12:24, Jarkko Sakkinen wrote:
> > On Wed, Jun 20, 2018 at 07:17:54AM +0200, Peter Rosin wrote:
> > > Locking the root adapter for __i2c_transfer will deadlock if the
> > > device sits behind a mux-locked I2C mux. Switch to the finer-grained
> > > i2c_lock_bus with the I2C_LOCK_SEGMENT flag. If the device does not
> > > sit behind a mux-locked mux, the two locking variants are equivalent.
> > >
> > > Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
> >
> > Studied enough so that I can give
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> >
> > Do not have hardware to test this, however.
>
> I don't have a mux-locked I2C mux either, but at least I can confirm
> that this change did not break my existing test setup (SLB9635/SLB9645
> on Raspberry Pi 2B).
>
> Tested-by: Alexander Steffen <Alexander.Steffen@xxxxxxxxxxxx>
>
> Alexander

Given the scope of the change and since analogous change works for
every other subsystem, this should be enough! Thank you.

/Jarkko