Re: [PATCH] drm/amd/display: don't initialize result

[Harry Wentland]

On 2018-06-17 04:53 AM, Stefan Agner wrote:
> The wrong enum type is used to initialize the result, leading to a
> warning when using clang:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1998:26: warning:
>       implicit conversion from enumeration type 'enum ddc_result' to different
>       enumeration type 'enum dc_status' [-Wenum-conversion]
>         enum dc_status result = DDC_RESULT_UNKNOWN;
>                        ~~~~~~   ^~~~~~~~~~~~~~~~~~
> 1 warning generated.
> 
> Initialization of result is unnecessary anyway, just drop the
> initialization.
> 
> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>

Thanks for the patch.

Reviewed-by: Harry Wentland <harry.wentland@xxxxxxx>

Ill merge this today.

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 7857cb42b3e6..1dbfbfc0fd45 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -1995,7 +1995,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
>  {
>  	union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}};
>  	union device_service_irq device_service_clear = { { 0 } };
> -	enum dc_status result = DDC_RESULT_UNKNOWN;
> +	enum dc_status result;
>  	bool status = false;
>  	/* For use cases related to down stream connection status change,
>  	 * PSR and device auto test, refer to function handle_sst_hpd_irq
>