Re: [PATCH v2] gpu: drm: armada: Adding new typedef vm_fault_t
From: Souptick Joarder
Date: Tue Jun 26 2018 - 12:07:46 EST
On Tue, Jun 26, 2018 at 9:07 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxx> wrote:
> On Tue, Jun 19, 2018 at 10:42:15AM +0530, Souptick Joarder wrote:
>> On Mon, Jun 4, 2018 at 10:46 AM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> > On Wed, May 23, 2018 at 3:09 PM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> >> On Wed, May 16, 2018 at 10:05 AM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
>> >>> On Fri, May 11, 2018 at 2:52 PM, Russell King - ARM Linux
>> >>> <linux@xxxxxxxxxxxxxxx> wrote:
>> >>>> On Thu, May 10, 2018 at 08:34:48PM +0530, Souptick Joarder wrote:
>> >>>>> Use new return type vm_fault_t for fault handler in
>> >>>>> struct vm_operations_struct. For now, this is just
>> >>>>> documenting that the function returns a VM_FAULT
>> >>>>> value rather than an errno. Once all instances are
>> >>>>> converted, vm_fault_t will become a distinct type.
>> >>>>>
>> >>>>> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>> >>>>>
>> >>>>> Previously vm_insert_pfn() returns err which driver
>> >>>>> mapped into VM_FAULT_* type. The new function
>> >>>>> vmf_insert_pfn() will replace this inefficiency by
>> >>>>> returning VM_FAULT_* type.
>> >>>>>
>> >>>>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> >>>>> Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>> >>>>
>> >>>> Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>> >>>>
>> >>>> Thanks.
>> >>>
>> >>> If no further comment, we would like to get this patch in queue
>> >>> for 4.18.
>> >>
>> >> We would like to get this patch in queue
>> >> for 4.18.
>> >
>> > We would like to get this patch in 4.18.
>>
>> Russell, This patch is not merged in 4.18-rc-1.
>
> Correct, I wasn't able to add it to my tree because David Airlie hadn't
> pulled the previous merge request, so it missed the 4.18 merge window.
>
> The reason for me acking the patch was so that /someone else/ could
> pick it up instead, and that obviously also didn't happen - maybe the
> drm-misc tree was closed for new work at the point you sent the patch.
>
> I've picked this patch up now, thanks.
>
Thanks. Queued for 4.19 merge window ?