Re: [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally

From: Oleksandr Natalenko
Date: Tue Jun 26 2018 - 16:44:14 EST


Hi.

On 25.06.2018 21:55, Paolo Valente wrote:
Hi,
during some bandwidth tests, I found some occasional but severe
malfunctions (losses of bandwidth control). The first three patches in
this series fix the bugs that caused these malfunctions. The last
patch is a fix/improvement of the name of one of the functions
involved with these bugs.

I guess these patches are appropriate for next kernel release.

Thanks,
Paolo

Paolo Valente (4):
block, bfq: add/remove entity weights correctly
block, bfq: do not expire a queue that will deserve dispatch plugging
block, bfq: fix service being wrongly set to zero in case of
preemption
block, bfq: give a better name to bfq_bfqq_may_idle

block/bfq-iosched.c | 131 +++++++++++++++++++++++++++++++++++++++++++---------
block/bfq-iosched.h | 7 ++-
block/bfq-wf2q.c | 30 ++++++------
3 files changed, 128 insertions(+), 40 deletions(-)

--
2.16.1

So far, no smoke or visible issues while running it on my 2 SSDs with a daily workload applied.

Tested-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>

Thanks.

--
Oleksandr Natalenko (post-factum)