Re: [PATCH v2] mtd: rawnand: mxc: remove __init qualifier from mxcnd_probe_dt

From: Miquel Raynal
Date: Wed Jun 27 2018 - 05:02:03 EST


Hi Martin,

On Wed, 27 Jun 2018 10:52:37 +0200, Martin Kaiser <martin@xxxxxxxxx>
wrote:

> Using the sysfs unbind, bind nodes, mxcnd_probe and mxcnd_probe_dt can
> potentially be called at any time. After the __init functions are cleaned,
> mxcnd_probe_dt is no longer available. Calling it anyway causes a crash.
>
> mxcnd_probe used to be marked as __init, this was removed years ago.
> Remove the __init qualifier from from mxcnd_probe_dt as well.
>
> Fixes: 06f2551 ("mtd: remove use of __devinit")

Nitpick: the Fixes tag should use at least the 12 first characters of
the SHA-1 ID, see:

https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html#describe-your-changes

Thanks,
MiquÃl