Re: [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init()

From: Pavel Tatashin
Date: Wed Jun 27 2018 - 23:20:06 EST


> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
>
> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>

Please remove duplicated signed-off

> if (!usemap) {
> ms->section_mem_map = 0;
> + nr_consumed_maps++;

Currently, we do not set ms->section_mem_map to 0 when fail to
allocate usemap, only when fail to allocate mmap we set
section_mem_map to 0. I think this is an existing bug.

Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>