Re: [PATCHv2 07/11] atomics: add common header generation files

[Mark Rutland]

On Mon, Jun 25, 2018 at 11:59:48AM +0100, Mark Rutland wrote:
> diff --git a/scripts/atomic/gen-atomic-long.sh b/scripts/atomic/gen-atomic-long.sh

> +cat << EOF
> +// SPDX-License-Identifier: GPL-2.0
> +
> +// Generated by $0
> +// DO NOT MODIFY THIS FILE DIRECTLY
> +
> +#ifndef _ASM_GENERIC_ATOMIC_LONG_H
> +#define _ASM_GENERIC_ATOMIC_LONG_H
> +
> +#include <asm/types.h>
> +
> +#ifdef CONFIG_64BIT
> +typedef atomic64_t atomic_long_t;
> +#define ATOMIC_LONG_INIT(i)		ATOMIC64_INIT(i)
> +#define atomic_long_cond_read_acquire	atomic64_cond_read_acquire
> +#else
> +typedef atomic_t atomic_long_t;
> +#define ATOMIC_LONG_INIT(i)		ATOMIC_INIT(i)
> +#define atomic_long_cond_read_acquire	atomic_cond_read_acquire
> +#endif

I forgot to add atomic_long_cond_read_relaxed() here, so I've added that
locally.

i.e. I now have:

#ifdef CONFIG_64BIT
typedef atomic64_t atomic_long_t;
#define ATOMIC_LONG_INIT(i)		ATOMIC64_INIT(i)
#define atomic_long_cond_read_acquire	atomic64_cond_read_acquire
#define atomic_long_cond_read_relaxed	atomic64_cond_read_relaxed
#else
typedef atomic_t atomic_long_t;
#define ATOMIC_LONG_INIT(i)		ATOMIC_INIT(i)
#define atomic_long_cond_read_acquire	atomic_cond_read_acquire
#define atomic_long_cond_read_relaxed	atomic_cond_read_relaxed
#endif

... with <asm-generic/atomic-long.h> regenerated appropriately.

Peter, I assume that your ack holds with that change.

Thanks,
Mark.