Re: [PATCH 0/2] tools/memory-model: remove ACCESS_ONCE()
From: Paul E. McKenney
Date: Thu Jun 28 2018 - 11:19:46 EST
On Thu, Jun 28, 2018 at 02:38:45PM +0200, Andrea Parri wrote:
> On Thu, Jun 28, 2018 at 01:33:45PM +0100, Mark Rutland wrote:
> > Since commit:
> >
> > b899a850431e2dd0 ("compiler.h: Remove ACCESS_ONCE()")
> >
> > ... there has been no definition of ACCESS_ONCE() in the kernel tree,
> > and it has been necessary to use READ_ONCE() or WRITE_ONCE() instead.
> >
> > However, since then the kernel memory model was added to the Linux tree,
> > sporting new instances of ACCESS_ONCE() in examples and in the memory
> > model itself.
> >
> > These patches remove the new instances of ACCESS_ONCE() for consistency
> > with the contemporary codebase.
> >
> > Thanks,
> > Mark.
> >
> > Mark Rutland (2):
> > tools/memory-model: remove ACCESS_ONCE() from recipes
> > tools/memory-model: remove ACCESS_ONCE() from model
>
> For the series:
>
> Acked-by: Andrea Parri <andrea.parri@xxxxxxxxxxxxxxxxxxxx>
Applied, thank you both! These both are ready for the upcoming merge
window.
While I am at it, here is the current scorecard:
e9ff68680cd4 tools/memory-model: Add litmus test for full multicopy atomicity
c21fcc6594f1 tools/memory-model: Fix ISA2+pooncelock+pooncelock+pombonce name
aa838e0b70e1 MAINTAINERS: Add Daniel Lustig as an LKMM reviewer
3cb0d7701c4c locking/memory-barriers.txt/kokr: Update Korean translation to fix broken DMA vs. MMIO ordering example
0bde941f3629 tools/memory-model: Remove ACCESS_ONCE() from recipes
80b7b05c3aa0 tools/memory-model: Remove ACCESS_ONCE() from model
The above patches are ready for the upcoming merge window because
each has at least one Acked-by or Reviewed-by.
6098ce88bc4d tools/memory-model: Make scripts executable
5bb22d0126f9 tools/memory-model: Rename litmus tests to comply to norm7
1bc179880fba docs: atomic_ops: Describe atomic_set as a write operation
The above patches need at least one additional Acked-by
or Reviewed-by. If any of you gets a chance, please do
look them over.
51b0a8985c5a EXP tools/memory-model: Add litmus-test naming scheme
This patch needs me to get Will Deacon's feedback applied. :-/
06e99a0d9662 EXP tools/memory-model: Add .cfg and .cat files for s390
This is a placeholder, and probably won't ever go upstream
into the Linux kernel. (Maybe someday into herd where the
other architecture-specific .cat files live.)
Thanx, Paul
> Cheers,
> Andrea
>
>
> >
> > tools/memory-model/Documentation/recipes.txt | 4 ++--
> > tools/memory-model/linux-kernel.bell | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > --
> > 2.11.0
> >
>