Re: [PATCH v2 0/3] printk: Deadlock in NMI regression

From: Sergey Senozhatsky
Date: Thu Jun 28 2018 - 21:52:23 EST


On (06/28/18 12:54), Petr Mladek wrote:
>
> On Thu 2018-06-28 11:39:02, Sergey Senozhatsky wrote:
> > On (06/27/18 16:08), Petr Mladek wrote:
> > >
> > > kernel/printk/printk.c | 57 +++++++++++++++++++++++++++-----------------
> > > kernel/printk/printk_safe.c | 58 +++++++++++++++++++++++++++++----------------
> >
> > Shall we just merge these two?
>
> Do you mean to merge files or the patches, please?

Yeah... dunno. We now lock logbuf spinlock outside of printk.c, and
we now have printk.c functions that have that "printk guts, must be
called under logbuf lock" requirement and so on. I like when static
things are static :)

-ss