Re: [PATCH v3] lightnvm: pblk: expose generic disk name on pr_* msgs

[Javier Gonzalez]

> On 29 Jun 2018, at 13.45, Matias BjÃrling <mb@xxxxxxxxxxx> wrote:
> 
> The error messages in pblk does not say which pblk instance that
> a message occurred from. Update each error message to reflect the
> instance it belongs to, and also prefix it with pblk, so we know
> the message comes from the pblk module.
> 
> Signed-off-by: Matias BjÃrling <mb@xxxxxxxxxxx>
> 
> ---
> 
> v3:
>  - Missing kfree's when spec not supported.
> v2:
>  - Forgot to test with NVM_PBLK_DEBUG on. Fixed up the broken code.
> ---
> drivers/lightnvm/pblk-core.c     | 51 ++++++++++++-------------
> drivers/lightnvm/pblk-gc.c       | 32 ++++++++--------
> drivers/lightnvm/pblk-init.c     | 80 ++++++++++++++++++++--------------------
> drivers/lightnvm/pblk-rb.c       |  8 ++--
> drivers/lightnvm/pblk-read.c     | 25 +++++++------
> drivers/lightnvm/pblk-recovery.c | 44 +++++++++++-----------
> drivers/lightnvm/pblk-sysfs.c    |  5 +--
> drivers/lightnvm/pblk-write.c    | 21 ++++++-----
> drivers/lightnvm/pblk.h          | 29 ++++++++++-----
> 9 files changed, 155 insertions(+), 140 deletions(-)
> 

Looks good to me.

Thanks!

Reviewed-by: Javier GonzÃlez <javier@xxxxxxxxxxxx>

Attachment: signature.asc
Description: Message signed with OpenPGP