Re: [PATCH 2/2] perf test shell: make perf inet_pton test more portable
From: Kim Phillips
Date: Fri Jun 29 2018 - 12:11:40 EST
On Fri, 29 Jun 2018 12:21:55 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> Em Thu, Jun 21, 2018 at 03:32:50PM -0500, Kim Phillips escreveu:
> > On Thu, 21 Jun 2018 12:18:00 -0300
> > Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> >
> > > Would be good if we had some utility that given a two files, one with
> > > regexps, could tell if, line by line, those expressions matched, better,
> > > one that is present in all these OSes...
> >
> > I didn't find any, but given the two-file notion might be acceptable,
> > hopefully you might find the following more readable/acceptable?:
>
> Looks better, you build the expected lines in a separate file, then read
> both it and the output, then do the matching, cleaner. And I assume it
> works with dash, right?
Yes, of course :)
I'll re-send via a new v2 series as 1/2 wasn't git-am friendly, and
I've uncovered another minor bashism.
Kim