Re: [PATCHv3 2/4] nvme: use hw qid in trace events

From: Keith Busch
Date: Fri Jun 29 2018 - 16:24:03 EST


On Fri, Jun 29, 2018 at 01:59:58PM -0600, Keith Busch wrote:
> + TP_printk("qid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
> + __entry->qid, __entry->nsid, __entry->cid,

Ugh, the nsid and cid are swapped here, and carried through to the end
of the series. Will need to send a v4.