Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration"

From: Randy Dunlap
Date: Fri Jun 29 2018 - 16:29:08 EST


On 06/29/2018 12:28 PM, Mike Rapoport wrote:
> Hi Randy,
>
> On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote:
>> On 06/29/2018 06:42 AM, Mike Rapoport wrote:
>>> Otherwise mm configuration options show up in the top level menu.
>>>
>>> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
>>
>> Hi Mike,
>>
>> In which config tool does this matter?
>>
>> For xconfig, it seems to me that this patch hides the MM menu, whereas
>> before this patch, the MM menu is easy to find (although it could
>> use some kind of heading).
>
> With xconfig the menu gets into the top right pane when you click on "ARC
> architecture configuration", similar to what one gets on x86 with
> "Processor type and features" or "Kernel features" on ARM.
>
> With menuconfig it looks a bit more prominent, note that mm options are
> between "ARC Architecture Configuration" and "Networking support":

I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig.

I would prefer to see Memory Management options have its own top-level
menu, but that's a different patch. Then menuconfig would look like this:



â â *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** â â
â â General setup ---> â â
â â [*] Enable loadable module support ---> â â
â â [*] Enable the block layer ---> â â
â â ARC Architecture Configuration ---> â â
â â Memory Management options ---> â â
â â (11) Maximum zone order â â
â â [*] Networking support ---> â â
â â Device Drivers ---> â â
â â Bus Support --->


but that "Maximum zone order" needs to be moved or taken care of somehow.


[snip]

>
>
>
>>> default "12" if ARC_HUGEPAGE_16M
>>> default "11"
>>>
>>> +endmenu # "ARC Architecture Configuration"
>>> +
>>> source "net/Kconfig"
>>> source "drivers/Kconfig"


thanks,
--
~Randy