Re: [PATCH v2 3/3] dt-bindings: clock: Modify Actions Soc clock bindings

[Saravanan Sekar]

Hi Mani,


On 07/01/18 19:37, Manivannan Sadhasivam wrote:
> On Sun, Jul 01, 2018 at 07:26:20PM +0200, Saravanan Sekar wrote:
> > Hi Mani
> >
> >
> > On 06/30/18 11:32, Manivannan Sadhasivam wrote:
> > > Hi Saravanan,
> > >
> > > I agree with modifying the existing binding to accomodate other
> > > SoC's of the same family. But the binding should be
> > > "actions,owl-cmu.txt" since it reflects the family name.
> > Agree, will modify the name
> >
> > > Andreas, what do you think?
> > >
> > > On Thu, Jun 28, 2018 at 09:18:05PM +0200, Saravanan Sekar wrote:
> > > > Modify clock bindings common Actions Semi Soc family S700/S900.
> > > >
> > > > Signed-off-by: Parthiban Nallathambi <pn@xxxxxxx>
> > > > Signed-off-by: Saravanan Sekar <sravanhome@xxxxxxxxx>
> > > > ---
> > > >    ...tions,s900-cmu.txt => actions,sx00-cmu.txt} | 18 ++++++++++--------
> > > >    1 file changed, 10 insertions(+), 8 deletions(-)
> > > >    rename Documentation/devicetree/bindings/clock/{actions,s900-cmu.txt => actions,sx00-cmu.txt} (71%)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/clock/actions,s900-cmu.txt b/Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
> > > > similarity index 71%
> > > > rename from Documentation/devicetree/bindings/clock/actions,s900-cmu.txt
> > > > rename to Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
> > > > index 93e4fb827cd6..8dc7edb4d198 100644
> > > > --- a/Documentation/devicetree/bindings/clock/actions,s900-cmu.txt
> > > > +++ b/Documentation/devicetree/bindings/clock/actions,sx00-cmu.txt
> > > > @@ -1,12 +1,14 @@
> > > > -* Actions S900 Clock Management Unit (CMU)
> > > > +* Actions S900/S700 Clock Management Unit (CMU)
> > > Same as above. Should be Actions OWL SoC's Clock Management Unit (CMU).
> > sure
> During the review of I2C controller driver, Andreas pointed out that
> we should use Owl instead of OWL in all places and also Actions should
> be replaced by Actions Semiconductor. So, please change it in relevant
> places. For this binding, title should be:
>
> Actions Semiconductor Owl SoC's Clock Management Unit (CMU).


Ok will change as mentioned above.

> Thanks,
> Mani
>
> > > > -The Actions S900 clock management unit generates and supplies clock to various
> > > > -controllers within the SoC. The clock binding described here is applicable to
> > > > -S900 SoC.
> > > > +The Actions S900/S700 clock management unit generates and supplies clock to
> > > > +various controllers within the SoC. The clock binding described here is
> > > > +applicable to S900/S700 SoC.
> > > >    Required Properties:
> > > > -- compatible: should be "actions,s900-cmu"
> > > > +- compatible: should be one of this
> > > Change to: compatible: should be one of the following:
> > sure
> >
> > > Thanks,
> > > Mani
> > >
> > > > +	"actions,s900-cmu"
> > > > +	"actions,s700-cmu"
> > > >    - reg: physical base address of the controller and length of memory mapped
> > > >      region.
> > > >    - clocks: Reference to the parent clocks ("hosc", "losc")
> > > > @@ -15,9 +17,9 @@ Required Properties:
> > > >    Each clock is assigned an identifier, and client nodes can use this identifier
> > > >    to specify the clock which they consume.
> > > > -All available clocks are defined as preprocessor macros in
> > > > -dt-bindings/clock/actions,s900-cmu.h header and can be used in device
> > > > -tree sources.
> > > > +All available clocks are defined as preprocessor macros in corresponding
> > > > +dt-bindings/clock/actions,s900-cmu.h or s700-cmu.h header and can be used in
> > > > +device tree sources.
> > > >    External clocks:
> > > > --
> > > > 2.18.0
> > Thanks,
> > Saravanan