From: Peng Li <lipeng321@xxxxxxxxxx>Agree with you.
Date: Fri, 29 Jun 2018 19:23:00 +0800
@@ -228,8 +228,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)I would advise against this.
desc_to_use = &hw->cmq.csq.desc[hw->cmq.csq.next_to_use];
*desc_to_use = desc[handle];
(hw->cmq.csq.next_to_use)++;
- if (hw->cmq.csq.next_to_use == hw->cmq.csq.desc_num)
- hw->cmq.csq.next_to_use = 0;
+ hw->cmq.csq.next_to_use %= hw->cmq.csq.desc_num;
handle++;
The "%" modulus operation takes many cpu cycles, and the current code
is thus much faster.
.