Re: [Xen-devel] [PATCH] xen: setup pv irq ops vector earlier

[Juergen Gross]

On 02/07/18 13:18, Jan Beulich wrote:
>>>> On 02.07.18 at 12:00, <jgross@xxxxxxxx> wrote:
>> --- a/arch/x86/xen/enlighten_pv.c
>> +++ b/arch/x86/xen/enlighten_pv.c
>> @@ -1213,6 +1213,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
>>  	pv_info = xen_info;
>>  	pv_init_ops.patch = paravirt_patch_default;
>>  	pv_cpu_ops = xen_cpu_ops;
>> +	xen_init_irq_ops();
> 
> Isn't this still too late? xen_setup_machphys_mapping(), for example,
> has a WARN_ON(), which implies multiple printk()s.

Seems as if it would be a good idea to move calling
xen_setup_machphys_mapping() into xen_init_mmu_ops(). There is really
no need to do it earlier.


Juergen