On Mon 02-07-18 11:14:58, Christian KÃnig wrote:
Am 27.06.2018 um 09:44 schrieb Michal Hocko:But such a code would be broken, no? Ignoring the blockable state will
This is the v2 of RFC based on the feedback I've received so far. TheThat sounds like it should work and at least the amdgpu changes now look
code even compiles as a bonus ;) I haven't runtime tested it yet, mostly
because I have no idea how.
Any further feedback is highly appreciated of course.
good to me on first glance.
Can you split that up further in the usual way? E.g. adding the blockable
flag in one patch and fixing all implementations of the MMU notifier in
follow up patches.
simply lead to lockups until the fixup parts get applied.
Is the split up really worth it? I was thinking about that but had hard
times to end up with something that would be bisectable. Well, except
for returning -EBUSY until all notifiers are implemented. Which I found
confusing.
This way I'm pretty sure Felix and I can give an rb on the amdgpu/amdkfdIf you are worried to give r-b only for those then this can be done even
changes.
for larger patches. Just make your Reviewd-by more specific
R-b: name # For BLA BLA