RE: [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static

[Mario.Limonciello]

> -----Original Message-----
> From: Colin King [mailto:colin.king@xxxxxxxxxxxxx]
> Sent: Saturday, June 30, 2018 7:10 AM
> To: Limonciello, Mario; Darren Hart; Andy Shevchenko; platform-driver-
> x86@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] platform/x86: dell-smbios-wmi: make function
> dell_smbios_wmi_call static
> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The function dell_smbios_wmi_call is local to the source and does not
> need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'dell_smbios_wmi_call' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Same vain as the other one of these, makes sense to me.

Acked-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

> ---
>  drivers/platform/x86/dell-smbios-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-
> smbios-wmi.c
> index fbefedb1c172..88afe5651d24 100644
> --- a/drivers/platform/x86/dell-smbios-wmi.c
> +++ b/drivers/platform/x86/dell-smbios-wmi.c
> @@ -82,7 +82,7 @@ static int run_smbios_call(struct wmi_device *wdev)
>  	return 0;
>  }
> 
> -int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
> +static int dell_smbios_wmi_call(struct calling_interface_buffer *buffer)
>  {
>  	struct wmi_smbios_priv *priv;
>  	size_t difference;
> --
> 2.17.1