Re: [PATCH] bindings: add clocks optional binding for imx gpio

[Linus Walleij]

On Fri, Jun 29, 2018 at 5:34 AM Anson Huang <Anson.Huang@xxxxxxx> wrote:

> Some i.MX SoCs have GPIO clock gate in CCM, accessing
> GPIO registers needs to enable GPIO clock gate first,
> i.MX GPIO driver will enable clock gate if there is
> clock property in GPIO node of dtb, add optional property
> to i.MX GPIO binding doc.
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>

Make sense since the gpio-mxc driver already supports this :)

> +Optional properties:
> +- clocks: the clocks used by gpio bank

Should the text be "the clock for clocking the GPIO silicon"
I guess that is what it is. And singularis?

Does it hurt to give the clock a name? Like the common
"pclk" for peripheral clock or something similar that other
i.MX silicon uses?

Fabio: can we have your ACK on this too.

Yours,
Linus Walleij