Re: [PATCH v2] x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD

[Brijesh Singh]

On 06/27/2018 11:30 AM, Janakarajan Natarajan wrote:
> Prevent a config where KVM_AMD=y and CRYPTO_DEV_CCP_DD=m thereby ensuring
> that AMD Secure Processor device driver will be built-in when KVM_AMD is
> also built-in.
>
> v1->v2:
> * Removed usage of 'imply' Kconfig option.
> * Change patch commit message.
>
> Fixes: 505c9e94d832 ("KVM: x86: prefer "depends on" to "select" for SEV")
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.16.x
> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@xxxxxxx>
> ---

Reviewed-by: Brijesh Singh <brijesh.singh@xxxxxxx>


>   arch/x86/kvm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 92fd433..1bbec38 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -85,7 +85,7 @@ config KVM_AMD_SEV
>   	def_bool y
>   	bool "AMD Secure Encrypted Virtualization (SEV) support"
>   	depends on KVM_AMD && X86_64
> -	depends on CRYPTO_DEV_CCP && CRYPTO_DEV_CCP_DD && CRYPTO_DEV_SP_PSP
> +	depends on CRYPTO_DEV_SP_PSP && !(KVM_AMD=y && CRYPTO_DEV_CCP_DD=m)
>   	---help---
>   	Provides support for launching Encrypted VMs on AMD processors.
>