Re: [PATCH] mm/sparse: Make sparse_init_one_section void and remove check

[Pavel Tatashin]

On Mon, Jul 2, 2018 at 11:43 AM <osalvador@xxxxxxxxxxxxxxxxxx> wrote:
>
> From: Oscar Salvador <osalvador@xxxxxxx>
>
> sparse_init_one_section() is being called from two sites:
> sparse_init() and sparse_add_one_section().
> The former calls it from a for_each_present_section_nr() loop,
> and the latter marks the section as present before calling it.
> This means that when sparse_init_one_section() gets called, we already know
> that the section is present.
> So there is no point to double check that in the function.
>
> This removes the check and makes the function void.
>
> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>

Thank you Oscar.

Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>

> ---
>  mm/sparse.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)